[haiku-bugs] [Haiku] #13599: [Patch] media/BufferConsumer.cpp: Fix ordered comparison between pointer and zero

  • From: "mt" <trac@xxxxxxxxxxxx>
  • Date: Wed, 12 Jul 2017 11:40:29 -0000

#13599: [Patch] media/BufferConsumer.cpp: Fix ordered comparison between pointer
and zero
----------------------------+------------------------------
 Reporter:  mt              |        Owner:  Barrett
     Type:  bug             |       Status:  new
 Priority:  normal          |    Milestone:  Unscheduled
Component:  Kits/Media Kit  |      Version:  R1/Development
 Keywords:                  |   Blocked By:
 Blocking:                  |  Has a Patch:  0
 Platform:  All             |
----------------------------+------------------------------
 Since 'group' is pointer, I think comparison at line 272 may be replaced
 to null pointer check.

 http://cgit.haiku-os.org/haiku/tree/src/kits/media/BufferConsumer.cpp#n272
 {{{
 /home/haiku/haiku/haiku/src/kits/media/BufferConsumer.cpp:272:12: error:
 ordered comparison between pointer and zero ('BBufferGroup *' and 'int')
         if (group > 0) {
             ~~~~~ ^ ~
 }}}

--
Ticket URL: <https://dev.haiku-os.org/ticket/13599>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: