[haiku-bugs] Re: [Haiku] #12890: WebPositive doesn't properly draw HTML buttons.

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Sat, 18 Sep 2021 15:35:59 -0000

#12890: WebPositive doesn't properly draw HTML buttons.
---------------------------------+---------------------------------
  Reporter:  Giova84             |      Owner:  pulkomandy
      Type:  bug                 |     Status:  new
  Priority:  normal              |  Milestone:  Unscheduled
 Component:  Kits/Interface Kit  |    Version:  R1/Development
Resolution:                      |   Keywords:
Blocked By:                      |   Blocking:  15449, 16158, 16754
  Platform:  All                 |
---------------------------------+---------------------------------
Comment (by madmax):

 Replying to [comment:8 nephele]:

Please retest with
 
https://git.gryphno.de/nephele/haikuwebkit/commit/011fd13722bee5df64c41a6a22420b6d7b015d46

 Seems to work, except with menu buttons (the popups are right), like the
 ones here in trac for issues filters, when they are outside the bounds
 before scrolling. This is probably due to stuff like
 
[https://github.com/haiku/haiku/blob/ed246fcd6ee31ba7bbeabb2b09166e4d058451a5/src/kits/interface/HaikuControlLook.cpp#L3086
 this] in HaikuControlLook, and not your patch. It also does not show the
 background of clicked buttons with the Be control look correctly, but
 again that is probably a problem in BeControlLook or InvertRect.

 I guess similar changes are needed for other be_control_look uses, both in
 RenderThemeHaiku.cpp and in ScrollbarThemeHaiku.cpp, as it's not just
 buttons suffering this.
-- 
Ticket URL: <https://dev.haiku-os.org/ticket/12890#comment:14>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: