#12620: Use a map for finding areas in ServerMemoryAllocator
------------------------------------+-----------------------------------
Reporter: Anarchos | Owner: axeld
Type: enhancement | Status: new
Priority: low | Milestone: Unscheduled
Component: Kits/Application Kit | Version: R1/Development
Resolution: | Keywords: ServerMemoryAllocator
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
------------------------------------+-----------------------------------
Comment (by axeld):
Thanks for you contribution. A couple of quick remarks:
* The coding style is questionable. Please have a look at our coding style
guidelines (for example, naming of variables). Trying not to make the code
stick out would be a good start.
* Your spacing seems to be off -- we use tabs for indentation, not spaces.
The spacing in the original file is okay.
* Don't leave commented out code in your patches.
* Please use a typedef for the map.
* What is "!ret_insert.second" supposed to do?
* Instead of std::pair, a dedicated structure would make the code a lot
more readable.
* Areas don't seem to be deleted anymore on destruction.
* What's the point in submitting code you didn't even test?
Most issues make your patch very hard to read and evaluate.
--
Ticket URL: <https://dev.haiku-os.org/ticket/12620#comment:3>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
