[haiku-bugs] Re: [Haiku] #11306: "package add" no longer works
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Thu, 09 Oct 2014 10:05:55 -0000
#11306: "package add" no longer works
--------------------------------+----------------------------
Reporter: ttcoder | Owner: bonefish
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Kits/Package Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
--------------------------------+----------------------------
Comment (by bonefish):
Thanks for your analysis, Michael! Your patch looks OK, but I'd rather
avoid a flag to temporarily change the behavior of a method. Since
`_UnwriteLastPartialChunk()` is meant to circumvent the usual mechanism of
reading data, I'd rather not call `ReadData()` at all. For a single known
chunk `ReadDataToOutput()` doesn't do much more than call
`ReadAndDecompressChunk()` anyway, which in turn only calls
`ReadAndDecompressChunkData()`. So calling the latter directly shouldn't
result in much code duplication, but it would be clearer and even avoid a
bit of overhead.
--
Ticket URL: <https://dev.haiku-os.org/ticket/11306#comment:9>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
