[haiku-bugs] Re: [Haiku] #11117: FAT: issues with lowercase 8.3 filenames
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Sun, 09 Nov 2014 11:29:46 -0000
#11117: FAT: issues with lowercase 8.3 filenames
--------------------------------+----------------------------
Reporter: MatejHorvat | Owner: nobody
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: File Systems/FAT | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
--------------------------------+----------------------------
Comment (by pulkomandy):
The variable name "toLower" used for an uint8 is confusing (we would
expect a bool with that name). I would either pass two booleans to the
function (lowerBase and lowerExtension for example) or find a better name
for the variable (caseFlags maybe?)
A comment explaining what's going on and how the flags are used may be
helpful, as there are a lot of magic numbers here (0xC, 0x10, 0x8, ...).
These should be constants.
--
Ticket URL: <https://dev.haiku-os.org/ticket/11117#comment:7>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
