[haiku-bugs] Re: [Haiku] #10367: Fix Coverity CID 1032247 and 1032248: unchecked return value

  • From: "bonefish" <trac@xxxxxxxxxxxx>
  • Date: Sun, 10 Aug 2014 07:14:17 -0000

#10367: Fix Coverity CID 1032247 and 1032248: unchecked return value
--------------------------------+------------------------------
   Reporter:  noryb009          |      Owner:  axeld
       Type:  bug               |     Status:  new
   Priority:  normal            |  Milestone:  R1/alpha5
  Component:  Kits/Storage Kit  |    Version:  R1/Development
 Resolution:                    |   Keywords:  gci2013 coverity
 Blocked By:                    |   Blocking:
Has a Patch:  1                 |   Platform:  All
--------------------------------+------------------------------

Comment (by bonefish):

 In practice seeking back cannot fail. The arguments (fFile, oldPosition)
 are known to be valid. If someone else concurrently truncates or removes
 the file, `fseeko()` will still succeed. The only possible error situation
 is, when the file is closed concurrently. However, in this case it is
 irrelevant that the seek operation failed, since it isn't possible to do
 any further reads/writes anyway.

 Since that would involve a programming error on the API user's side,
 calling `debugger()` or logging the error would be an option. I'd still
 return success, though.

--
Ticket URL: <https://dev.haiku-os.org/ticket/10367#comment:7>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: