[haiku-bugs] Re: [Haiku] #10301: [debug_server] Allow configuring a default action on program crashes
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Sun, 15 Dec 2013 20:45:15 -0000
#10301: [debug_server] Allow configuring a default action on program crashes
------------------------------------+----------------------------
Reporter: anevilyak | Owner: anevilyak
Type: enhancement | Status: in-progress
Priority: normal | Milestone: Unscheduled
Component: Servers/debug_server | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
------------------------------------+----------------------------
Comment (by bonefish):
I only had a quick look. A few comments:
* I would read the settings whenever a team crashes. This allows changing
the settings at run-time without having to restart the debug server.
* `static int32 action_for_string()`: Missing line break.
* The code in `Init()` relies on the "default_action" setting being
specified before any "executable_actions" (`fDefaultDebugAction` is used
for the latter).
* It probably doesn't make much of a difference in this case, but there's
a private C++ API for driver settings access, which may be more convenient
to use (headers/private/storage/DriverSettings.h).
* I don't think support for case insensitive settings is needed.
--
Ticket URL: <http://dev.haiku-os.org/ticket/10301#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts: