[haiku-bugs] Re: [Haiku] #10141: DriveSetup: add image menu
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Sat, 26 Oct 2013 21:48:28 -0000
#10141: DriveSetup: add image menu
---------------------------------------+----------------------------
Reporter: dsjonny | Owner: stippi
Type: enhancement | Status: new
Priority: low | Milestone: R1
Component: Applications/DriveSetup | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
---------------------------------------+----------------------------
Comment (by axeld):
Thanks for the patch! The basic idea is good, but the patch has a number
of issues:
* There is unused stuff in it like write/save image menu items, whatever
you thought they could do one day, unused things don't belong into a
patch.
* The naming is strange "load" and "unload" is even more cryptic than
register and unregister. Why not just "Mount image" and "Remove image"?
* It leaks the file panel.
* A few minor coding style issues (like '{' after case -- it goes to the
next line there).
--
Ticket URL: <http://dev.haiku-os.org/ticket/10141#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
