Hi,
I really don't think we should do this rename; while the names do violate
the style guide, I think we should make an exception for them.
Additionally now that the beta is out, we should be trying to avoid ABI
breaks wherever possible. This obviously is not very important and indeed
can be avoided...
-waddlesplash
On Sat, Apr 13, 2019, 5:55 PM Pranali Deshmukh <pranali21293@xxxxxxxxx>
wrote:
Hi,
As part of an effort to make API names consistent across the entire
project, I have recently submitted a patch (
https://review.haiku-os.org/c/haiku/+/1310) for #6921 (
https://dev.haiku-os.org/ticket/6921) to rename BUrl* & BHttp* to BURL*
and BHTTP*. This has been done since all other similar cases in the Haiku
API are named in uppercase only, like BGLView, BUSBRoster, etc.
This change however breaks WebPositive (WebKit) at the moment, since it
extensively uses the BUrl* classes, which have been updated as part of the
changeset here. Thus, updates need to be made within WebKit as well to
support these changes and as such, I would be looking into submitting a
patch for WebKit to introduce these updates to it with the help of
@PulkoMandy.
Along with this, we also need to update all 3rd party apps which use these
APIs to make sure that going forward they work as expected on Haiku once
this patch is merged. As such, if you are the maintainer of any apps that
use these classes or if you are aware of any apps using any methods from
these classes it would be great if you can help me submit patches to these
apps as well to make sure that they are compatible with these changes.
Regards,
Pranali Deshmukh
