[gpodder-devel] Don't check on_quit_ask if on_quit_systray is set
- From: andreas.boettger at gmx.de (Andreas Böttger)
- Date: Tue, 15 Sep 2009 22:05:19 +0200
Ok, I understand. That was my first patch, sorry for that.
2009/9/15 Gergely Imreh <imrehg at gmail.com>
> 2009/9/15 Andreas B?ttger <andreas.boettger at gmx.de>:
> > sorry for the format cleanup. Should I send no patch if only on line
> > differs?
> >
> > Andreas
>
> That's not what I meant, it's great to have patches.
>
> I just tried to suggest, that as a good practice, one patch should do
> one thing at a time. Eg. one patch for the change (one line is still a
> fix), and another one with the format cleanup (good to get rid of all
> those spurious whitespaces, cheers!). I think your other patch had
> similar "mixture". Then one patch for one fix, another for the other,
> and a third one for the cleanup of all the files that you wanted to
> clean.
>
> Hope this will be somewhat helpful.
> Cheers,
> Greg
> _______________________________________________
> gpodder-devel mailing list
> gpodder-devel at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/gpodder-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.berlios.de/pipermail/gpodder-devel/attachments/20090915/a703b6a3/attachment.html>
Other related posts:
