[gmpi] Re: calling C from C++

  • From: Tim Hockin <thockin@xxxxxxxxxx>
  • To: gmpi@xxxxxxxxxxxxx
  • Date: Sun, 13 Feb 2005 20:12:38 -0800

Let's nitpick :)

On Mon, Feb 14, 2005 at 04:46:32PM +1300, Jeff McClintock wrote:
> ---------------------gmpi.h -----------------------------------
> 
> #if !defined( GMPI_H_INCLUDED )

if !defined() better than ifndef, for some reason?

>       GMPI_VTABLE_PREFIX /* compatiblilty with COM binary standard on Mac*/

The comment is self-defeating.  It's  amacro precisely because we don't
know what might need to be there.  The macro name is self-documenting.

How do people feel about really long lines? I've always been a proponent
of wrapping code at 78 columns, myself...

Otherwise, it looks ok.  I have some questions, because I am still not
clear on some things, but I'll read your other email first.

Tim

----------------------------------------------------------------------
Generalized Music Plugin Interface (GMPI) public discussion list
Participation in this list is contingent upon your abiding by the
following rules:  Please stay on topic.  You are responsible for your own
words.  Please respect your fellow subscribers.  Please do not
redistribute anyone else's words without their permission.

Archive: //www.freelists.org/archives/gmpi
Email gmpi-request@xxxxxxxxxxxxx w/ subject "unsubscribe" to unsubscribe

Other related posts: