Re: late changes

  • From: <tpgww@xxxxxxxxxxx>
  • To: emelfm2@xxxxxxxxxxxxx
  • Date: Sat, 15 Feb 2014 12:00:50 +1100

On Wed, 12 Feb 2014 10:32:32 -0600
Adam Krolnik <akrolnik@xxxxxxxxx> wrote:

> Well, when I execute emelfm2 src, it does accept the relative source and
> places it in the second pane instead of the first.

This choice was discussed in a ML thread some time back.
 
> 
> But if I do this:
> L%  ./emelfm2 -1 src/command -2 src/config
> 
> It does not accept them. You did not call e2_cl_option_get_path() for -1
> and -2 args.

Indeed. For those options, the path-interpretation was intended to occur later 
in the startup process (actually, in e2_fs_get_valid_path()). But that also 
would need to handle relative a path string - and now it does. And anyway, it's 
probably more reliable to interpret the CWD ASAP during startup, so I've also 
applied _e2_cl_option_get_path() to -1, -2 options. 

> 
> Also, WITH_CUSTOMMOUSE=1 (and KEYFAKE ) needs this patch.
> 
> svn diff src/e2_mousebinding.c
> Index: src/e2_mousebinding.c
> ===================================================================
> --- src/e2_mousebinding.c   (revision 3053)
> +++ src/e2_mousebinding.c   (working copy)
> @@ -1760,7 +1760,7 @@
>   fake_data.buttons_string = fakes;
> 
>   gdk_event_free (event);
> - _e2_keybinding_fake_events (&fake_data);
> + _e2_mousebinding_fake_events (&fake_data);
>   WAIT_FOR_EVENTS;
>   return TRUE;
>  }

Applied, thanks.

Regards
Tom.


-- 
Users can unsubscribe from the list by sending email to 
emelfm2-request@xxxxxxxxxxxxx with 'unsubscribe' in the subject field or by 
logging into the web interface.

Other related posts: