[dokuwiki] Re: darcs patch: parenthesis_escaper_fix
- From: Stephane Chazelas <stephane.chazelas@xxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Fri, 4 Jan 2008 14:55:37 +0000
On Fri, Jan 04, 2008 at 03:31:25PM +0100, Andreas Gohr wrote:
> Hi!
Hi Andi,
> > > Could you please rewrite the patch using a for loop with the length
> > > of the array instead of using a reference?
> > [...]
> >
> > I was wondering why that convoluted style of loop was being
> > used, I wasn't aware of that limitation of older releases of PHP
> > as I'm a very occasional PHP programmer, sorry about that.
> >
> > Please find the new patch attached (gzip compressed).
>
> Looks like you sent the wrong file. It still uses
>
> foreach ($elts[0] as &$elt) {
[...]
Oops, I had only taken care of the outer loop. Sorry. Here's
another patch. Just removed the "&" above.
Cheers,
Stephane
Other related posts:
