[dokuwiki] Re: Strike-through Button

  • From: Koen Huybrechts <huybkoen@xxxxxxxxx>
  • To: dokuwiki@xxxxxxxxxxxxx
  • Date: Sun, 05 Jun 2005 16:02:19 +0200

Chris Brotherton wrote:

On Sat, Jun 04, 2005 at 12:15:08PM -0600, Chris Brotherton wrote:


I use dokuwiki as a todo list and I like to strike-through completed items
using the <del></del> tags.  Since I use these tags so often, I thought it
would be useful to add a "Strike-through Text" button.  This patch will add
the button:

__________________________________________________________________________

{
hunk ./inc/html.php 855
+          
formatButton('images/strike.png','<?=$lang['qb_strike']?>','<del>','</del>','<?=$lang['qb_strike']?>','d');
hunk ./lang/en/lang.php 100
+$lang['qb_strike']  = 'Strike-through Text';
}

__________________________________________________________________________

The problem with the patch is that it points to a non-existent image.  Could
whoever created the images (Andi I suspect) create an image for
strike-through?  It could probably be something simple like a couple of
characters with a strike through it.  I could make the image myself, but it
will probably take me longer to try and match the style/font of the other
images.  If someone could make the new image available, I will include it with
the patch and submit the patch to Andi.

My patch only includes the label for the button in english.

The shortcut button is "ALT+D" since "ALT+S" is already taken, but this can
easily be changed.

Chris.



Here is a patch to include a strike-through button. It also includes the image file created using the empty.png file. The access key is "ALT + D".

Chris.


------------------------------------------------------------------------


New patches:

[Strike-through Text Button
chris@xxxxxxxxxxxxx**20050604231701] {
addfile ./images/strike.png
binary ./images/strike.png
oldhex
*
newhex
*89504e470d0a1a0a0000000d4948445200000018000000180806000000e0773df800000006624b
*474400ff00ff00ffa0bda793000000097048597300001ec100001ec101c3695453000000077449
*4d4507d50604161e1eb8e098b5000002704944415478daad95cd4b1b5114c57fefcd24cd6cdaa0
*0c2a5611bf0a85ae5cd7ffc07dbac8c28d20dd05c4952bc19d0bc155b36cfe155d4a94d6408808
*6a516762f361269f9dde6e262131686b9d038779306fee79e7de79f7028c01fb8084c42fc03b20
*0a2805ec5f5c5c7c8ec7e3f44329f5cfebeed3f77daeafaf595858c80029a0a2002997cb944a25
*94522fa6effb8c8e8e02bc077e6800ad7528c1955298a6d935f8067865f6db0d837d88005a3f37
*b86ddbcf11e1d90efeb6f7217498020fffb29e40ffa6cbcb4b565757999b9b636a6a8a442241b1
*581c08b2b7b7c7fcfc3ce3e3e3acafaf53afd707841f7500904c26595b5be3f4f4945c2ec7e2e2
*225b5b5b031f1d1c1c707878c8c9c909373737ececec3cea4001e2791ed56a15c330867258afd7
*595a5a229fcfa39462646484a3a3236667670128140aacacac50281400300c83582c06b00ce409
*04c26a13d26ab5baeb8fc0582f45b7b7b7388ec3c4c404e9749ab3b3335cd7e5fcfc1c8072b94c
*a55201209bcde2791e9ee791cd66999c9ca4d96cd26ab59e2e3240b3d9241a8d625916575757a4
*52a9a1026e6e6ee2380eaeebb2b1b1412291e8bdd75a0fa5591a8d86388e23aeeb4a2693919999
*19310c43a6a7a76577775700a956ab727f7f2f806c6f6f8b6ddb625996249349a9542ad26eb7a5
*d3e988effb0329528100b55a2d9456a1b5eeba5806f23acc3ef4d77b1076f09e40bbdd0e4de0ee
*ee6e48209dcbe510112ccb2212890cd034cd276918466f9e944a258e8f8f01be037e506cde025f
*439cc9df804fc00720ae82e1fc1ab0832964062de47ff10ba80145e0a70a824580582066f032fc
*063a4003e8a8078d4fbdf0f4bdcbdbe51fdfc32d17081733380000000049454e44ae426082
hunk ./inc/html.php 855
+          
formatButton('images/strike.png','<?=$lang['qb_strike']?>','<del>','</del>','<?=$lang['qb_strike']?>','d');
hunk ./lang/en/lang.php 100
+$lang['qb_strike']  = 'Strike-through Text';
}

Context:

[extended search fix
matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx**20050604212026
This patch fixes a bug in the search code and did some
optimizations. Furtheron queries with only excluded
words will be rejected because they won't produce
usable output and waste only time.
] [extended search fix
matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx*-20050604194621
This patch fixes a bug in the search code and did some
small optimizations.


The possibility to start a search with _only_ excluded
words (only words start with a minus sign) was disabled
because this seem to crash PHP 4.3.10 (at least the ppc
version :-()
] [much better Opera 8 AJAX fix (no fallback to GET needed)
andi@xxxxxxxxxxxxxx**20050604215355] [AJAX fix for Opera 8
andi@xxxxxxxxxxxxxx**20050604211320] [extended search fix
matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx**20050604194621
This patch fixes a bug in the search code and did some
small optimizations.


The possibility to start a search with _only_ excluded
words (only words start with a minus sign) was disabled
because this seem to crash PHP 4.3.10 (at least the ppc
version :-()
] [removed SACK warning for older browsers #369
andi@xxxxxxxxxxxxxx**20050604185143
Older Browsers (Opera) got a warning from the new AJAX stuff. It's a bug
in SACK described at
http://twilightuniverse.com/2005/05/sack-of-ajax/#comment-594
I just removed it from tw-sack.js


I also added the line suggested at
http://twilightuniverse.com/2005/05/sack-of-ajax/#comment-597 - not
used yet but may come in handy

] [nl update
Jack van Klaren <dokuwiki@xxxxxxxxxxxxxxxxx>**20050604184408] [Mediafile Deletion and Overwrite Handling #200
andi@xxxxxxxxxxxxxx**20050603205501
This patch enhances the ACL feature by adding another Permission called DELETE - this permission
allows a user to delete or overwrite existing mediafiles. Users with UPLOAD permission are no longer
allowed to overwrite media files.
Users whith DELETE permissions now need to check an additional checkbox to overwrite existing files,
this is to prevent accidently deletions.


Please note: If no ACL is used UPLOAD rights are assumed for everybody - not DELETE rights. This
changes the behaviour from previous versions as UPLOAD does not allow overwriting anymore.
] [extended search function
matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx**20050603182746
The DokuWiki search function uses 'OR' to combine
multiple search words. This behaviour is unusual and
not very helpful to narrow the search results.
This patch changed the behaviour to 'AND'. Multiple
search words will reduce the count of search results.


It uses assertions now. This has the big advantage
that only one regular expression have to be processed
for each file and the behaviour can be changed easily.

The functionallity has been extended: Words with a
preceding minus sign (-) will be excluded from and
words with a preceding plus sign (+) will be included
in the search results. Is a preceding sign is missing
(+) is assumed.
] [keep search input on search page
matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx**20050601163504
This patch modifies the search input form so that the search input
is kept as long as the user stays on the search page. This is pure
comfort because he is able to optimise his query step by step without
the need of typing in the query multiple times.
] [String quoting in TOC toggle code
matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx**20050531193827
This patch changed the string quoting in the TOC toggle button code.
The HTML code looks better.
] [toc toggle button
matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx**20050531184155
The TOC toggle button was very small and inconspicuous. This patch
replaces the old one with small arrows placed at the right border
of the TOC header.
Code cleanup in html.php: html_toc() and html_list_toc() are obsolete
and have been removed.
] [add a back button to parent page
matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx**20050519174025
This patch extends the template functions with back
button linking to the current pages' parent if
available. Both tpl_button() and tpl_actionlink()
are supported.


For this to work the first page in the namespace must
have the same name as the namespace itself. The 'back'
button of every page in this namespace links to namespace:namespace. The 'back' button of the page
namespace:namespace links to the first page of the containing namespace and so forth until the start page
has been reached.


Because of the precondition decribed above, the default
template hasn't got the new 'back' button. It is reserved
for custom made templates and installations which take
care of the precondition.
] [TAG develsnap 2005-05-31
andi@xxxxxxxxxxxxxx**20050531214447] Patch bundle hash:
0c8665e8e21c95dd19ef17cadacca3b679d01b54


Hi,

While pulling the last 4 buttons, Darcs didn't proceed and I aborted it. Then I pulled the patches one by one. The first 2 of them weren't a problem, but the third one was (the one about the button)

I got this error:



C:\Documents and Settings\koko\Bureaublad>cd c:\apachefriends\xampp\htdocs\dokuw
iki

C:\apachefriends\xampp\htdocs\dokuwiki>darcs pull
Pulling from "http://dev.splitbrain.org/darcs/dokuwiki";...
No remote changes to pull in!

C:\apachefriends\xampp\htdocs\dokuwiki>pause
Druk op een toets om door te gaan. . .

C:\apachefriends\xampp\htdocs\dokuwiki>cd c:\apachefriends\xampp\htdocs\koko

C:\apachefriends\xampp\htdocs\koko>darcs pull c:\apachefriends\xampp\htdocs\doku
wiki
Pulling from "c:\apachefriends\xampp\htdocs\dokuwiki"...

Sun Jun  5 13:03:02 Romance (standaardtijd) 2005  chris@xxxxxxxxxxxxx
 * Strike-through Quick Button
Shall I pull this patch? (1/2) [ynWvxqadjk], or ? for help:

Sun Jun  5 13:07:14 Romance (standaardtijd) 2005  andi@xxxxxxxxxxxxxx
 * moved lang directory into inc dir
Shall I pull this patch? (2/2) [ynWvxqadjk], or ? for help:
We have conflicts in the following files:
./inc/html.php ./lib ./lib/images ./lib/images/toolbar
You have conflicting local changes to:
./lib ./lib/images ./lib/images/strike.png ./lib/images/toolbar ./lib/images/too
lbar/strike.png



Is it possible he didn't find the right folder? What can i do about it?? (I can 
make a folder, but when I delete that folder, the button doesn't work, or does 
it still work?)

I can't tell you more about it...

koko


Other related posts: