Hi,
micgro42 opened a new pull request at
https://github.com/splitbrain/dokuwiki/pull/2190:
It would be helpful if there were a reliable way to determine the current mode
in javascript, for example, if we only want to execute some javascript in
`show` or `preview` modes. This writes the final mode to the `$JSINFO` object
right before it is written out as a header, so we can hopefully capture the
actual mode without a plugin changing it later on.
## To Do/Discuss
- [ ] I would like to initialize $JSINFO in `lib/exe/detail.php` as well. Which
keys should be included?
- [ ] There are several lines in `lib/exe/js.php` that might be suitable to be
included in `JSINFO` (see below). Which one should we include in `JSINFO` and
can we somehow show a deprecation notice if the old variables are used?
https://github.com/splitbrain/dokuwiki/blob/479b8450994e5a47eff744c623b3ae14afcee19c/lib/exe/js.php#L94-L103
Please help us to review this pull request, so new contributors get feedback in
a timely manner.
68b1b6b0-de70-11e7-81b5-1618ee493f53
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
