[codeface] Re: [PATCH] Generate log output when loading corpus instead of .mbox file

  • From: Mitchell Joblin <joblin.m@xxxxxxxxx>
  • To: codeface@xxxxxxxxxxxxx
  • Date: Thu, 12 Nov 2015 20:00:57 +0000

Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx> schrieb am Do., 12.
Nov. 2015 20:15:

Hi Mitchell,

Am 12/11/2015 um 16:42 schrieb Mitchell Joblin:

- It's easy to forget or not be aware of stale data messing with
the mailing list analysis

actually, re-using the data has in the past more often lead
to problems than benefits for me. Do you need this feature?
Maybe we should keep it, but require an explicit parameter
to make use of it.

It's only useful for debugging and should not be used in production.
Should it be useful for you,

then

I only use it during development but even that's getting more rare now that
we have some test data to work with. I will make the default behavior load
the mbox file.

Thanks,

Mitchell

Acked-by: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx>

Thanks, Wolfgang

Signed-off-by: Mitchell Joblin <mitchell.joblin.ext@xxxxxxxxxxx>
---
codeface/R/ml/analysis.r | 1 +
1 file changed, 1 insertion(+)

diff --git a/codeface/R/ml/analysis.r b/codeface/R/ml/analysis.r
index 556511d..be4e4d8 100644
--- a/codeface/R/ml/analysis.r
+++ b/codeface/R/ml/analysis.r
@@ -52,6 +52,7 @@ gen.forest <- function(conf, repo.path, resdir) {
preprocess=linux.kernel.preprocess)
save(file=corp.file, corp.base)
} else {
+ loginfo("Loading mail data from precomputed corpus instead of mbox
file")
load(file=corp.file)
}


Other related posts:

  1. Home
  2. codeface
  3. Archive
  4. 11-2015