[codeface] [PATCH 2/4] Bug Fix: statement incorrectly in loop scope

  • From: Mitchell Joblin <joblin.m@xxxxxxxxx>
  • To: codeface@xxxxxxxxxxxxx
  • Date: Thu, 3 Apr 2014 18:25:40 +0200

- seems like the commit message does not need to be inside
  the loop and it means that we are double counting tags
  and wasting cycles on parsing the same message twice

Signed-off-by: Mitchell Joblin <mitchell.joblin.ext@xxxxxxxxxxx>
---
 codeface/VCS.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/codeface/VCS.py b/codeface/VCS.py
index c91b582..28eeee4 100644
--- a/codeface/VCS.py
+++ b/codeface/VCS.py
@@ -529,9 +529,9 @@ class gitVCS (VCS):
                     log.exception("Could not spawn git")
                     raise
 
-            # The commit message is independent of the diff type, so we
-            # can re-use the information in msg
-            self._analyseCommitMsg(msg, cmt)
+        # The commit message is independent of the diff type, so we
+        # can re-use the information in msg
+        self._analyseCommitMsg(msg, cmt)
 
 
 
-- 
1.8.3.2


Other related posts: