[atreus] Re: Problems with QMK firmware
- From: Stefano Rodighiero <stefano.rodighiero@xxxxxxxxx>
- To: atreus@xxxxxxxxxxxxx
- Date: Wed, 11 Oct 2017 15:44:51 +0200
On Sun, Oct 1, 2017 at 9:13 PM, Stefano Rodighiero <
stefano.rodighiero@xxxxxxxxx> wrote:
On Sun, Oct 1, 2017 at 7:11 PM, Phil Hagelberg <phil@xxxxxxxxxx> wrote:
[...]
I've ported this approach to QMK on this branch:
https://github.com/technomancy/qmk_firmware/tree/atreus-pcbdown
but I don't have a board on hand right now with the PCB installed
down. Go ahead and give this a try, and if it works I'll submit it as a
PR to the main QMK repo.
I tried and it works! Thank you.
I opened a PR as well on your fork, a simple reformulation of
the default keymap using the KEYMAP macro.
After talking with Phil I am more willing to submit the change
as a PR against the original QMK repo.
I don't have a non-PCBDOWN to to a regression test of my
change, tho'. Can someone help me ?
Here the fork with my changes (I only modified the Default
and Classic layouts. To test, just compile the layout, flash it
over on your keyboard and verify keys behave appropriately):
https://github.com/larsen/qmk_firmware/tree/atreus-keymap-macro
thank you.
s.
--
www.stefanorodighiero.net
Other related posts:
