[procps] Re: newlib, ps fix

  • From: Jim Warner <james.warner@xxxxxxxxxxx>
  • To: procps@xxxxxxxxxxxxx
  • Date: Thu, 27 Aug 2015 08:15:02 -0500

On 08/27/2015 07:55 AM, Craig Small wrote:

w scans the process table and adds the cpu for processes for
that user. should it be
procps_pids_new
procps_pids_read_open
while procps_pids_read_next
if user match then
add the cpu lines
if best process
copy the fields out of stacks
procps_pids_read_shut
procps_pids_unref

No, w currently uses readproctab so with newlib he'll
procps_pids_new
procps_pids_reap
...
procps_pids_unref

Also why read_open and read_shut? is this to differentiate from the
other access method?

i would of thought the file method would work.
fopen
while fgets
fclose

eg procps_pids_open, procps_pids_read, procps_pids_close

We still new procps_pids_new, and I fell in love with the 4 letter suffix. Plus, my names sort better I think.

Jim



Other related posts: