[procps] Re: [PATCH] Clean README

  • From: Jim Warner <james.warner@xxxxxxxxxxx>
  • To: procps@xxxxxxxxxxxxx
  • Date: Fri, 2 Mar 2012 08:47:48 -0600

On Mar 2, 2012, at 4:26 AM, Sami Kerola wrote:

> Seeing Jims patches merged to upstream I decided to make the merge
> request a lot easier. They all are now in one branch. Reason I'm doing
> this is to avoid difficult merge we had with nls branch. Please
> review, and if necessary cherry pick only the good stuff. More
> important than getting everything merged is to get closure to merge
> requests.
> 
> git://gitorious.org/~kerolasa/procps/sami-procps-ng.git combo-merge

Hi Sami,

I think you might want to remove that last merge from your combo-merge branch.

Craig was reluctant to add page fault deltas for top because it broke the 
libprocps ABI.  The changes that David Cantrell has offered would break even 
the API.

Even though it might mean some code duplication, I think such API changes 
should be handled as new exports whenever possible.  In that way the existing 
API would remain unchanged.

Regards,
Jim



Other related posts: