[procps] Re: Improving some regexp in tests for accounting for more, situations.

  • From: Pierre Labastie <pierre.labastie@xxxxxxx>
  • To: procps@xxxxxxxxxxxxx
  • Date: Wed, 10 Apr 2013 22:23:02 +0200

Le 07/04/2013 10:44, Craig Small a écrit :
> On Sat, Apr 06, 2013 at 08:45:12PM +0200, Pierre Labastie wrote:
>> 
> 
>> The one in vmstat is for the case where something like sr0 with more than 
>> ten reads, appears
>> before sda in /proc/diskstats, which seems to occur sometimes. The fix 
>> supposes that there is at least one partition
>> of the form [hs]d[a-z]\d on the computer.
> I've not included this one. I do understand there needs to be a fix.
> Perhaps the tcl equivalent of "[a-z]{3,}\\d+" will do it? sr0 and fd0
> are two alphas, not three so don't match.  Maybe its a 'not as bad as we
> had it' situation here.
> 
>  - Craig

It seems that [hsvx]{1,2}d[a-z]\d+ would do it. With tcl escapes, it would be 
\[hsvx\]\{1,2\}d\[a-z\]\\d+ (suggestion of B. Dubbs from LFS).
Now, is it possible to have only lvm logical volumes (with names dm-<digit>), 
or nfs and/or nbd drives on diskless hosts (partitions on nbd drives are 
nbd<digit>p<digit>)? None of those would match the current regexp either.

Pierre

Other related posts:

  • » [procps] Re: Improving some regexp in tests for accounting for more, situations. - Pierre Labastie