[pisa-src] Re: r1505 - in trunk: libpisa/global.h libpisa/util.c pisacd/cdmain.c pisasd/sdmain.c
- From: René Hummen <rene.hummen@xxxxxxxxxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Wed, 04 Nov 2009 00:06:05 +0100
On Nov 3, 2009, at 9:04 PM, Diego Biurrun wrote:
On Tue, Nov 03, 2009 at 04:50:31PM +0100, René Hummen wrote:
Log:
Modified behavior of pisa*d when hipd is not started upfront.
The previous implementation would start a hipd from the path.
That's what I would call expected behavior, what else is it supposed
to
do?
Simple: not run the hipd. This should be the task of the user or the
init script structure.
Thus, it would be unknown to the user, which hipd is running
at the moment. This is especially fatal, when different
versions are available on the host and the user wants to use
a specific one.
'which hipd' should answer that.
What exactly is the problem you are trying to solve?
There is really no reason for pisa*d to transparently start an
instance of hipd. This should be handled elsewhere (see above).
--- trunk/pisacd/cdmain.c Tue Nov 3 15:11:34 2009 (r1504)
+++ trunk/pisacd/cdmain.c Tue Nov 3 16:50:30 2009 (r1505)
@@ -360,10 +361,18 @@
+ /* Check, whether hipd is running. This is a requirement for
+ * using pisacd. The output will be written to stderr before
+ * pisacd is forking to background */
+ while (TRUE)
TRUE? This is C, not C++, IMO just use '1' ...
Diego
---
Dipl.-Inform. René Hummen, Ph.D. Student
Distributed Systems Group
RWTH Aachen University, Germany
tel: +49 241 80 20772
web: http://ds.rwth-aachen.de/members/hummen
Other related posts:
