[pisa-src] Re: r1505 - in trunk: libpisa/global.h libpisa/util.c pisacd/cdmain.c pisasd/sdmain.c

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Tue, 03 Nov 2009 21:04:51 +0100

On Tue, Nov 03, 2009 at 04:50:31PM +0100, René Hummen wrote:
> 
> Log:
> Modified behavior of pisa*d when hipd is not started upfront.
> 
> The previous implementation would start a hipd from the path.

That's what I would call expected behavior, what else is it supposed to
do?

> Thus, it would be unknown to the user, which hipd is running
> at the moment. This is especially fatal, when different
> versions are available on the host and the user wants to use
> a specific one.

'which hipd' should answer that.

What exactly is the problem you are trying to solve?

> --- trunk/pisacd/cdmain.c     Tue Nov  3 15:11:34 2009        (r1504)
> +++ trunk/pisacd/cdmain.c     Tue Nov  3 16:50:30 2009        (r1505)
> @@ -360,10 +361,18 @@
> +     /* Check, whether hipd is running. This is a requirement for
> +      * using pisacd. The output will be written to stderr before
> +      * pisacd is forking to background */
> +     while (TRUE)

TRUE?  This is C, not C++, IMO just use '1' ...

Diego

Other related posts: