[nvda-addons] Re: commit/Emoticons: norrumar: Removed \1 from smile, since it's not needed and would have to be a raw string to work.

  • From: Brendon C Donohue <brendoncdonohue@xxxxxxxxxx>
  • To: nvda-addons@xxxxxxxxxxxxx
  • Date: Mon, 21 Oct 2013 21:46:49 +1000

Great sounds good! Thanks for all of your great work!



-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Mesar Hameed
Sent: Monday, 21 October 2013 5:31 AM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: commit/Emoticons: norrumar: Removed \1 from
smile, since it's not needed and would have to be a raw string to work.

Hi Chris,
Ok, taking Brendon and Noelia's feedback I have gone ahead and done the
change from smiley smile, to smiling smiley.

I hope the changes don't create too many merge conflicts for you.

Noelia can upload it as dev when she has time, and we can wait a few days
while people test and to give you time to do the remaining emoticons.
Then we can provide the translators with the po file.

thanks,
Mesar
On Sat 19/10/13,14:52, Ch-L wrote:
> Hi Mesar,
> I asked to English speaker, and he said that is more correct so:
> smile Smiley.
> But I have used the same way used in browser-mode, for example, when 
> we read a web page NVDA first say the label:
> link subscribe;
> lists of 8 item Main menu...
> Heading livel 1 Download...
> etc.
> 
> Note also, I used the same names of smiley or emoticons that appear in 
> Skype program.
> However, I also think the second option is more natural:
> Good morning smiling smiley.
> It's  even more beautiful.
> 
> Now  I am copying other smiley from Facebook. Many of those are 
> classical smiley and are used in various chat programs. If we want add 
> in to the our add-on, in short are ready.
> 
> Thanks.
> 
> 
> Chris()
> 
> Il 19/10/2013 13:29, Mesar Hameed ha scritto:
> >Hi,
> >
> >One last thing before making this addon available, it would be good to
hear from English speakers on this.
> >for something like:
> >
> >good morning :)
> >should it be:
> >1. good morning smiley smile
> >or:
> >2. good morning smiling smiley
> >
> >NVDA is the best :D
> >should it be:
> >1. NVDA is the best smiley laugh
> >or
> >2. NVDA is the best laughing smiley
> >
> >I think option 2 is more natural.
> >thoughts?
> >
> >thanks,
> >Mesar
> >On Tue 15/10/13,22:09, Noelia wrote:
> >>Hello, mostly for Chris and Mesar: I have seen that Mesar has 
> >>included a space before the translatable strings, and therefore the 
> >>emoticon name is separated. I hadn't noted it before. My dismissals 
> >>are known by people who know the way I am.
> >>I have deleted extra semicolons, cause they are included too. So I'm 
> >>going to delete dictionary files and merge into master.
> >>We can categorize NVDA+e as Speak, like similar scripts, and I think 
> >>that the add-on can be translated and tested when you want.
> >>Thanks.
> >>
> >>2013/10/15, Noelia <nrm1977@xxxxxxxxx>:
> >>>Hi Chris, I hadn't seen Mesar's commit. I have restored his 
> >>>changes, that I deleted though I didn't want to do it, and I think 
> >>>that smile is separated to the previous word without \1. But check 
> >>>if my last changes work properly. If not, we can add \\1 
> >>>automatically in replacement.
> >>>Perhaps we can remove the semicolon contained just in a few emoticons.
> >>>About your question, I think we can create other types of 
> >>>dictionaries, not just temporary, and remove entries or add them. I 
> >>>prefer to talk about thoughts and not to say that something is true 
> >>>since it is not tested.
> >>>Furthermore, would be useful to add a dialog for writing emoticons 
> >>>when we don't know how they are writing, or this function is 
> >>>implemented in the chat programs?
> >>>Cheers.
> >>>
> >>>2013/10/15, Ch-L <llajta@xxxxxx>:
> >>>>Hi Noelia,
> >>>>also \1 is used in each smiley, I added \1 or a simple space in 
> >>>>the dictionary to separate smiley announcement when there is a wor
vefore.
> >>>>I download also your previous change, seems a good solution.
> >>>>   Thanks.
> >>>>PS: peraps for a diferent script, do you know a way to disable 
> >>>>only a dic for specific synthesizer? And not hte others like a 
> >>>>temporarydic or default dic.
> >>>>Cheers.
> >>>>
> >>>>Chris()
> >>>>
> >>>>Il 15/10/2013 17:52, commits-noreply@xxxxxxxxxxxxx ha scritto:
> >>>>>1 new commit in Emoticons:
> >>>>>
> >>>>>https://bitbucket.org/nvdaaddonteam/emoticons/commits/308c1cb719e0/
> >>>>>Changeset:   308c1cb719e0
> >>>>>Branch:      noDicFile
> >>>>>User:        norrumar
> >>>>>Date:        2013-10-15 17:52:08
> >>>>>Summary:     Removed \1 from smile, since it's not needed and would
have
> >>>>>to be a raw string to work.
> >>>>----------------------------------------------------------------
> >>>>
> >>>>NVDA add-ons Central: A list for discussing NVDA add-ons
> >>>>
> >>>>To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
> >>>>
> >>>>To unsubscribe, send an email with the subject line of "unsubscribe"
> >>>>(without quotes) to nvda-addons-request@xxxxxxxxxxxxx.
> >>>>
> >>>>If you have questions for list moderators, please send a message 
> >>>>to nvda-addons-moderators@xxxxxxxxxxxxx.
> >>>>
> >>>>Community addons can be found here: http://addons.nvda-project.org
> >>>>
> >>>
> >>----------------------------------------------------------------
> >>
> >>NVDA add-ons Central: A list for discussing NVDA add-ons
> >>
> >>To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
> >>
> >>To unsubscribe, send an email with the subject line of "unsubscribe"
(without quotes) to nvda-addons-request@xxxxxxxxxxxxx.
> >>
> >>If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
> >>
> >>Community addons can be found here: http://addons.nvda-project.org
> >----------------------------------------------------------------
> >
> >NVDA add-ons Central: A list for discussing NVDA add-ons
> >
> >To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
> >
> >To unsubscribe, send an email with the subject line of "unsubscribe"
(without quotes) to nvda-addons-request@xxxxxxxxxxxxx.
> >
> >If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
> >
> >Community addons can be found here: http://addons.nvda-project.org
> >
> ----------------------------------------------------------------
> 
> NVDA add-ons Central: A list for discussing NVDA add-ons
> 
> To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
> 
> To unsubscribe, send an email with the subject line of "unsubscribe"
(without quotes) to nvda-addons-request@xxxxxxxxxxxxx.
> 
> If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
> 
> Community addons can be found here: http://addons.nvda-project.org

----------------------------------------------------------------

NVDA add-ons Central: A list for discussing NVDA add-ons

To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.

To unsubscribe, send an email with the subject line of "unsubscribe" (without 
quotes) to nvda-addons-request@xxxxxxxxxxxxx.

If you have questions for list moderators, please send a message to 
nvda-addons-moderators@xxxxxxxxxxxxx.

Community addons can be found here: http://addons.nvda-project.org

Other related posts: