Hi Joseph,
On Sat 10/01/15,16:30, Joseph Lee wrote:
As there were not bug reports and commits for a while, I'd like to propose
releasing SPL add-on 4.0.
Hopefully constructive criticism, which we also discussed on irc before
christmas.
I am not sure if you will get anyone to review the addon as it stands,
as it will take several hrs.
What workflow are you trying to follow? It seems way overcomplicated,
even a large project such as NVDA has a straightforward and
understandable flow to its branching model.
I thought you said in one of your previous emails that you have
simplified it?
The addon currently has 34 branches, and when commits are cherry-picked
rather than the branch is merged, it make things so much harder to see
where things came from/ended up at, and what has been reviewed previously.
As you know its only really Nolia and I that have been volunteering to
review peoples addons, any time taken reviewing code duplicates
is time taken from doing something more rewarding.
Can you please explain what branching strategy you have been using, and
remove branches that have already been merge/cherry picked.
I don't know how confident you are with git, but you could rewrite part
of your history on some new branches which are equivilent to the
existing once, after you check that they are equivilent then the dirty
branches can be deleted.
If you need Guidance on this let me know.
thanks,
Mesar
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
