That may actually be the desired answer. I just want to make sure I do not remove a printf statement where it should still exist.
Michael Whapples On 12/05/2014 12:56, Keith Creasy wrote:
I'm not sure what is best but when doing some work porting code from embedded Linux to Android I put in code that sent log messages to the Android logcat handlers but also continued to send messages to stdout and stderr. -----Original Message----- From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Michael Whapples Sent: Monday, May 12, 2014 7:49 AM To: liblouis-liblouisxml@freelists.orgKeith Subject: [liblouis-liblouisxml] Re: Preparing logging branch for inclusion The windows nmake stuff seems to be working fine. I have started on moving the logging code into logging.c. The removing of printf statements is less clear, I question whether some of those may be more desirable left as printf to stderr, (eg. out of memory messages). We may wish to also add logging of the message, but I could imagine always wanting that to stderr so the user is made aware why things stopped. Do people agree with that or do they feel it should go in logging and the controlling application decides how to show Error, Warning or Fatal messages from log (eg. for a gui application stderr probably doesn't make sense). Michael Whapples On 09/05/2014 13:04, Mesar Hameed wrote:Hi Michael, On Fri 09/05/14,12:30, Michael Whapples wrote:I was feeling that may be a separate source file should be created to deal with logging. How would I go about adding another source file so that the build system picks it up?I've just pushed a commit to your branch that should do the job. Things look ok when I build on Linux, but my modifications to the windows make file are untested. thanks, MesarFor a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com
For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com
