[liblouis-liblouisxml] Re: Calculation of cursorPos
- From: Christian Egli <christian.egli@xxxxxx>
- To: James Teh <jamie@xxxxxxxxxxxx>
- Date: Wed, 30 Jan 2013 10:25:41 +0100
James Teh <jamie@xxxxxxxxxxxx> writes:
> On 30/01/2013 9:20 AM, John J. Boyer wrote:
>> The code just has to check outputPos to make sure it is not NULL . The
>> change is near line 260 in lou_translateString.c .
> True, but ideally, whether now or later, it'd be good to eliminate the
> old cursorPos code, since it has bugs and isn't likely to be
> maintained.
I'd accept a patch that removes all the old cursorPos code (just
allocate outputPos if it is NULL). Less code means less bugs.
Another thing that seems to rub me the wrong way is that there is
apparently quite a bit of duplication in forward and backwards
translation. Many things in lou_translateString.c (including
transcommon.ci) and lou_backTranslateString.c essentially do the same.
The major differences seem to be bug fixes that have only been applied
to forward translation. I have a patch locally that reduces the
duplication somewhat. Maybe I'll put it on a branch one of these days.
Thanks
Christian
--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
Other related posts:
