Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)

From: Mateusz Loskot <mateusz@xxxxxxxxxx>
To: "Discussions/Questions about the i3 window manager" <i3-discuss@xxxxxxxxxxxxx>
Date: Fri, 13 Jul 2012 19:06:58 +0100

On Sun, Jul 8, 2012 at 4:31 AM, Michael Stapelberg <michael@xxxxxxxx> wrote:

1) You are not using FREE(last_urgent_ws);, but free(last_urgent_ws) in
line 1489, which is unsafe (it is not guaranteed that last_urgent_ws
is != NULL).

There is no such guarantee needed for free() as per the C99 Standard:

7.20.3.2 The free function
2 The free function causes the space pointed to by ptr to be
deallocated, that is, made
available for further allocation. If ptr is a null pointer, no action occurs.

Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net

Follow-Ups:
- Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)
  - From: Michael Stapelberg

References:
- Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)
  - From: DR
- Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)
  - From: Michael Stapelberg
- Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)
  - From: DR

Other related posts:

» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- DR
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Axel Wagner
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Fernando Lemos
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Michael Stapelberg
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Alexander Kalentyev
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Michael Stapelberg
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- DR
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- DR
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Michael Stapelberg
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- DR
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view) - Mateusz Loskot
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Michael Stapelberg
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Michael Stapelberg
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Mateusz Loskot
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- DR
» Re: [i3] [PATCH] Improved i3bar hide mode behavior (In my point of view)- Michael Stapelberg