[hipl-dev] Re: [Merge] lp:~stefan.goetz/hipl/hidb-lsidb into lp:hipl
- From: René Hummen <rene.hummen@xxxxxxxxxxxxxxxxx>
- To: mp+61833@xxxxxxxxxxxxxxxxxx
- Date: Sun, 05 Jun 2011 10:59:22 -0000
Review: Approve
> Hi Rene!
>
> Thanks for reviewing!
>
> > What happened to the hip_ prefix for functions?
>
> I did not use them because 1) they seem useless to me (or is there a
> reason why they are necessary?)
You are right. They are not necessary in the daemons, but they must be included
in the library functions.
> 2) there is no official policy about
> using them (at least not in doc/HACKING)
I will add this to the policies, once we agree that my answer to (1) is the way
to go.
> and 3) they are not used
> consistently throughout the code anyway.
True, but that doesn't mean we cannot improve the code as we go on ;-)
This proposal is good to be merged.
--
https://code.launchpad.net/~stefan.goetz/hipl/hidb-lsidb/+merge/61833
Your team HIPL core team is subscribed to branch lp:hipl.
Other related posts:
