[hipl-dev] Re: [Branch ~hipl-core/hipl/trunk] Rev 5955: Check whether daemon is running in openwrt init scripts.
- From: David Martin <david.martin.mailbox@xxxxxxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Wed, 15 Jun 2011 14:58:21 +0200
Hi,
every time I see a comment from you next to one of my commits there is
a moment of dread. What crime against common programming sense did I
commit now? ;-)
>> --- packaging/openwrt/hipl/files/hipd.init 2011-05-27 12:52:21 +0000
>> +++ packaging/openwrt/hipl/files/hipd.init 2011-06-08 16:40:25 +0000
>> @@ -5,23 +5,45 @@
>>
>> +stop_daemon() {
>> + PID=$(cat $PID_FILE)
>> + kill $PID >/dev/null
>
> I would suggest a space after the '>', but redirecting the output to
> /dev/null seems pointless anyway - I have never seen kill print
> anything to stdout...
>
> The same comment applies to the other file.
You are right. My initial thought for adding it was to get rid of the
'Terminated.' message that hipd sometimes prints to the terminal when
you exit it.
> root@nike:/etc/init.d# /etc/init.d/hipd stop
> Stopping hipdTerminated
It's not related though. I have removed the redirection in trunk revision 5967.
David
Other related posts:
