[hipl-dev] Re: [Branch ~hipl-core/hipl/trunk] Rev 5955: Check whether daemon is running in openwrt init scripts.
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Thu, 09 Jun 2011 20:59:54 +0200
On Wed, Jun 08, 2011 at 04:56:13PM +0000, noreply@xxxxxxxxxxxxx wrote:
> ------------------------------------------------------------
> revno: 5955
> committer: David Martin <david.martin.mailbox@xxxxxxxxxxxxxx>
> branch nick: hipl_init-scripts
> timestamp: Wed 2011-06-08 18:40:25 +0200
> message:
> Check whether daemon is running in openwrt init scripts.
>
> Both hipd and hipfw create a PID file with their process id. Check against
> it to determine whether we actually have to start or stop the daemon.
> In case the daemon is already running or stopped print a notice
> respectively.
> modified:
> packaging/openwrt/hipl/files/hipd.init
> packaging/openwrt/hipl/files/hipfw.init
>
> --- packaging/openwrt/hipl/files/hipd.init 2011-05-27 12:52:21 +0000
> +++ packaging/openwrt/hipl/files/hipd.init 2011-06-08 16:40:25 +0000
> @@ -5,23 +5,45 @@
>
> +stop_daemon() {
> + PID=$(cat $PID_FILE)
> + kill $PID >/dev/null
I would suggest a space after the '>', but redirecting the output to
/dev/null seems pointless anyway - I have never seen kill print
anything to stdout...
The same comment applies to the other file.
Diego
Other related posts:
