[hipl-dev] Re: [Branch ~hipl-core/hipl/trunk] Rev 5935: properly incorporate 'get map' in hipconf

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Thu, 09 Jun 2011 19:21:18 +0200

On Mon, May 16, 2011 at 04:33:24PM +0000, noreply@xxxxxxxxxxxxx wrote:
> ------------------------------------------------------------
> revno: 5935
> committer: Rene Hummen <rene.hummen@xxxxxxxxxxxxxxxxx>
> branch nick: trunk
> timestamp: Mon 2011-05-16 16:23:23 +0200
> message:
>   properly incorporate 'get map' in hipconf
>   
>   moved some code in own functions for improved readability.
> modified:
>   lib/core/conf.c
> 
> --- lib/core/conf.c   2011-05-16 11:39:06 +0000
> +++ lib/core/conf.c   2011-05-16 14:23:23 +0000
> @@ -1030,6 +1031,117 @@
>  
> +/**
> + *
> + */
> +static int hip_conf_add_id_to_ip_map(struct hip_common *const msg,
> +                                     const char *opt[],
> +                                     const int optc)

I'm surprised that Doxygen does not complain about missing
documentation...

> +/**
> + * ask hipd to map a HIT or LSI to a locator
> + *
> + * @param msg input/output message for the query/response for hipd
> + * @param action unused
> + * @param opt a HIT or LSI
> + * @param optc 1
> + * @param send_only 1 if no response from hipd should be requrested, or 0 if
> + *                  should block for a response from hipd
> + * @return zero for success and negative on error
> + */
> +static int hip_conf_get_id_to_ip_map(struct hip_common *msg,
> +                                     const char *opt[],
> +                                     int optc,
> +                                     int send_only)

It does complain here though:

~/src/hipl/hipl $ make doxygen
doxygen doc/Doxyfile
/home/biurrun/src/hipl/hipl/lib/core/conf.c:1105: warning: argument 'action' of 
command @param is not found in the argument list of 
hip_conf_get_id_to_ip_map(struct hip_common *msg, const char *opt[], int optc, 
int send_only)

Diego

Other related posts: