[haiku-gsoc] Re: [HCD]: Bfs bug #1

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-gsoc@xxxxxxxxxxxxx
  • Date: Thu, 19 Jun 2008 00:52:49 +0200

Salvatore Benedetto wrote:
> The patch attached should prevents the kernel from crashing in this 
> occasion making
> it more error prone. I called the boolean variable fOk. I really didn't 
> know how else to call
> it. Can somebody review it and give me his bless so that I can commit it 
> please?

How about "fIsValid", "fGetSucceeded" or "fInitialized"? And shouldn't it 
default to "false" (in the constructor)? What happens if someone calls 
Put() without having called Get() before?

Best regards,
-Stephan

Other related posts: