[haiku-gsoc] Re: [HCD]: Bfs bug #1

2008/6/18 Stephan Assmus <superstippi@xxxxxx>:
>
> Salvatore Benedetto wrote:
>> The patch attached should prevents the kernel from crashing in this
>> occasion making
>> it more error prone. I called the boolean variable fOk. I really didn't
>> know how else to call
>> it. Can somebody review it and give me his bless so that I can commit it
>> please?
>
> How about "fIsValid", "fGetSucceeded" or "fInitialized"? And shouldn't it
> default to "false" (in the constructor)? What happens if someone calls
> Put() without having called Get() before?

fGetSucceded I like it most. I can't really answer to your question yet, as I'm
not that familiar with the code.

>
> Best regards,
> -Stephan
>
>


Regards,
-- 
Salvatore Benedetto (a.k.a. emitrax)
Student of Computer Engineer
University of Pisa
www.haiku-os.it

Other related posts: