[haiku-commits] Re: haiku: hrev48664 - in src/add-ons/kernel: file_cache network/stack src

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 13 Jan 2015 12:38:50 +0100

Hi,

On 13.01.2015 11:47, Oliver Tappe wrote:
Adrien Destugues <pulkomandy@xxxxxxxxx> hat am 12. Januar 2015 um 23:56
geschrieben:


On Mon, Jan 12, 2015 at 10:12:46PM +0100, Oliver Tappe wrote:
[ ... ]
Well, as you know, we do have a testsuite. The fact that it isn't being run
as part of the automatic build process yet has no meaning whatsoever as long
as it doesn't contain any tests covering the code that has been changed.
I know writing tests can be somewhat difficult (especially for kernel code)
and not many people like writing tests to begin with, but blaming the
infrastructure is not really a good excuse.

Writing tests that are never run by anyone is even less motivating.

Well, the idea of course is that the developer planning to do refactorings has a
good
motivation to write tests and then run them before and after the refactoring.

However, it's not as if I would follow that advice myself (see my recent rewrite
of haikuporter's
dependency resolution for a bad example).

To me it seems these arguments about automatic testing and who should have written tests, are just pushing around the blame. I would like to focus instead on the question what was to be gained by replacing the hashing implementation and whether or not Haiku will now be less stable.

Best regards,
-Stephan


Other related posts: