[haiku-commits] Re: haiku: hrev48664 - in src/add-ons/kernel: file_cache network/stack src
- From: Adrien Destugues <pulkomandy@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 12 Jan 2015 23:56:18 +0100
On Mon, Jan 12, 2015 at 10:12:46PM +0100, Oliver Tappe wrote:
>
> On 2015-01-12 at 19:02:36 [+0100], Adrien Destugues <pulkomandy@xxxxxxxxx>
> wrote:
> [ ... ]
> > It would be great to have a more complete testsuite, but for this we
> > need to setup a buildbot running haiku so the tests can be run, and/or get
> > our automated unit tests to run on the libbe_test platform so the other
> > build bots can run the tests. Without an automated test suite, we can
> > only rely on ourselves and our users to manually test that the image
> > runs, and that everything works as expected. This is time-consuming for
> > everyone, but the fix is not stopping to make changes to the code.
>
> Well, as you know, we do have a testsuite. The fact that it isn't being run
> as part of the automatic build process yet has no meaning whatsoever as long
> as it doesn't contain any tests covering the code that has been changed.
> I know writing tests can be somewhat difficult (especially for kernel code)
> and not many people like writing tests to begin with, but blaming the
> infrastructure is not really a good excuse.
Writing tests that are never run by anyone is even less motivating. It's
also not an excuse: I did the changes and did my best to test them with
the available tools (which is not much: I can only check that the code
builds, and the resulting system boots on my machine). If this is not
enough to keep everyone confident that the code works, it's not because
it is a bad time to do the change, but because we need better testing
tools, and better tests.
--
Adrien.
Other related posts:
