[haiku-commits] Re: haiku: hrev47567 - src/kits/interface
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 25 Jul 2014 00:07:17 +0200
On 24.07.2014 17:14, jscipione@xxxxxxxxx wrote:
fef862e: TextView.h rearrage virtual methods for FBC
As has already being said (and I told you in IRC yesterday) this is
superfluous.
8e268f7: TextView: Fix FBC size breakage
In hrev46796 I added two new private methods: _PreviousLineStart(),
and _NextLineEnd() which increased the size of the class breaking
binary compatability because I forgot to decrement the reserved array.
This commit decrements the reserved array restoring the class size
to the original size fixing the binary compat issue.
Maybe you should ask if you don't understand something. I told you
exactly what you have to do, and you managed to do it wrong:
- you added boolean members, and that changed the class size.
- I even told you yesterday that methods don't change the class size
- The boolean members only account for a single int (ie., as I told you
356 against 360 bytes size), so the array size must be 5, not 4
Is it really that hard to even read? Maybe rereading the IRC log before
breaking everything just a bit differently would have made sense?
dc4ae0e: TextView: Fix regression for Home and End
... while Shift is held down in a selection.
Ouch, you didn't even manage to get this one right.
THE BEHAVIOR IS BROKEN WITHOUT HOLDING DOWN SHIFT, TOO. And that was
what I mentioned to you.
At least nice that you fixed another regression, even though you seem to
have borked it, too. The BeOS solution definitely makes sense. Please
implement that one instead.
Is it possible to forbid you to do any changes that change more than two
characters? This is really more than just a little annoying.
Bye,
Axel.
Other related posts:
