[haiku-commits] Re: haiku: hrev47567 - src/kits/interface
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 28 Jul 2014 12:27:41 +0200 (CEST)
> On July 25, 2014 at 1:53 AM John Scipione <jscipione@xxxxxxxxx> wrote:
> Axel, calm down and take a deep breath.
>
> I didn't figure out the problem at first but after some more research
> I learned what was going on and corrected the array size to be 5
> rather than 4 in hrev47568. [1]
I noticed that later, but it's really annoying that you:
1) commit before doing any research, but only start researching after the commit
2) are obviously not able to listen at all. What you wrote there in your 2nd
commit message is pretty much exactly what I told you in IRC. Even including the
byte sizes, and the commit that broke it.
If you are so weak at remembering/reading things, you should adapt your workflow
accordingly.
Since it's obviously futile, I'll stop communicating issues to you this way, but
open Trac tickets instead where the information is steadily available for you to
pick up as often as needed.
At least you learned something about FBC in the process which was the only
reason not to fix it myself. Hopefully it'll last a bit.
> > Is it really that hard to even read? Maybe rereading the IRC log before
> > breaking everything just a bit differently would have made sense?
> Unfortunately you mentioned the problem in the development channel
> which isn't logged AFAIK so I couldn't go back and re-read the
> discussion.
Then switch to an IRC client that does the logging for you. Like Vision. Similar
situations happened quite a few times already with the both of us talking in
IRC, and I guess I'm not the only person suffering from this.
> Maybe you should read the entire commits log before
> sending off an angry email and then you'd know that the problem was
> already corrected.
That's not the whole point, though. From my POV you sincerely earned that angry
mail.
In any case, kudos to your reaction to it, I liked that :-)
> >> dc4ae0e: TextView: Fix regression for Home and End
> >> ... while Shift is held down in a selection.
> > Ouch, you didn't even manage to get this one right.
> > THE BEHAVIOR IS BROKEN WITHOUT HOLDING DOWN SHIFT, TOO. And that was what I
> > mentioned to you.
> Again, calm down, I realize that there was a problem also when the
> shift key was not held down and I solved the problem in both cases.
Then please note that in the commit message. And also, please try to make your
commit messages more concise.
While I like the level of information you usually put in there, it would be
great if you could try to do it with less words.
It's basically the same as with comments in the code: be as concise and precise
as possible. Otherwise the information you want to deliver might be lost in the
shear amount of text.
> > At least nice that you fixed another regression, even though you seem to
> > have borked it, too. The BeOS solution definitely makes sense. Please
> > implement that one instead.
> I actually implemented the BeOS solution as well but I was and am
> reluctant to use it. There are pro's and con's on both sides and I am
> not convinced that the BeOS solution is superior.
I obviously did not understand how you implemented it. After having read
Stephan's explanation (assuming that's how it works now), I think you did it
right after all, so sorry for misjudging you not that nicely.
> > Is it possible to forbid you to do any changes that change more than two
> > characters? This is really more than just a little annoying.
> I'm sorry that you are annoyed, all I can do is apologize and to try
> and fix any issues that come up as soon as possible. Also, changing
> the array size only involved changing 1 character and I managed to
> still screw that up so I don't think that would completely solve the
> problem.
While that would make reviewing your commits substantially easier, I have to
admit it's not a really good solution.
Bye,
Axel.
Other related posts:
