[haiku-commits] Re: haiku: hrev45272 - src/kits/shared headers/private/shared

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Tue, 12 Feb 2013 12:51:48 -0500

On Tue, Feb 12, 2013 at 7:26 AM, "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote:
> Indentation looks wrong. For complete inline classed we do not indent this 
> way,
> anyway, though.

Okay, noted.

> But anyway, doesn't make it more sense to add this class to libshared.a? I'm
> sure it's used at other places, too.
> If it's already part of libbe.so anyway, we could also make it available for
> other Haiku components in a private namespace.

I was contemplating something on a similar line of thinking as I
shamelessly stole this code from Icon-O-Matic. What I'd like to do is
to create a (private for now) BPanel class that works exactly like a
BWindow except the window closes, or does whatever you've set
QuitRequested() to do, when you push the Escape key. The intention is
to someday make BPanel a public class in the Interface Kit that others
can use in their own applications perhaps before R1 perhaps after.
Sound okay?

Other related posts: