[haiku-commits] Re: haiku: hrev45272 - src/kits/shared headers/private/shared
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 12 Feb 2013 13:26:13 +0100 (CET)
On February 12, 2013 at 3:30 AM jscipione@xxxxxxxxx wrote:
> +class EscapeFilter : public BMessageFilter {
> + public:
> + EscapeFilter(BWindow*
> target)
> + :
> +
>
> BMessageFilter(B_ANY_DELIVERY,
> B_ANY_SOURCE),
> + fTarget(target)
> + {
> + }
> + virtual ~EscapeFilter()
> + {
> + }
> + virtual filter_result
> + Filter(BMessage* message,
> BHandler** target)
> + {
Indentation looks wrong. For complete inline classed we do not indent this way,
anyway, though.
But anyway, doesn't make it more sense to add this class to libshared.a? I'm
sure it's used at other places, too.
If it's already part of libbe.so anyway, we could also make it available for
other Haiku components in a private namespace.
Bye,
Axel.
Other related posts:
