[haiku-commits] Re: haiku: hrev45232 - in src: apps/drivesetup kits/interface

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 05 Feb 2013 15:03:58 +0100

Am 05/02/2013 01:11, schrieb John Scipione:

@@ -415,10 +416,11 @@ BMenuField::AttachedToWindow()
                 rgb_color color = parent->ViewColor();
                 if (color == B_TRANSPARENT_COLOR)
                         color = ui_color(B_PANEL_BACKGROUND_COLOR);
+       } else
+               color = ui_color(B_PANEL_BACKGROUND_COLOR);

Shouldn't this be set to B_MENU_BACKGROUND_COLOR instead of
B_PANEL_BACKGROUND_COLOR? By default they are the set to be the same
color but it is possible the change one or the other.
Nope, a BMenuField is just like any other control put into a view; it's the background color of the label and the field button. What you mean is probably the background color of the BMenuBar it uses to draw its field button. 

Bye,
   Axel.

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 02-2013