[haiku-commits] Re: haiku: hrev45232 - in src: apps/drivesetup kits/interface

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Mon, 4 Feb 2013 19:11:53 -0500

On Mon, Feb 4, 2013 at 5:08 PM,  <axeld@xxxxxxxxxxxxxxxx> wrote:

> diff --git a/src/kits/interface/MenuField.cpp 
> b/src/kits/interface/MenuField.cpp
> index cf261ab..e337e80 100644
> --- a/src/kits/interface/MenuField.cpp
> +++ b/src/kits/interface/MenuField.cpp
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright 2001-2011, Haiku, Inc.
> + * Copyright 2001-2013, Haiku, Inc.
>   * Distributed under the terms of the MIT License.
>   *
>   * Authors:
> @@ -408,6 +408,7 @@ void
>  BMenuField::AttachedToWindow()
>  {
>         CALLED();
> +       rgb_color color;
>
>         BView* parent = Parent();
>         if (parent != NULL) {
> @@ -415,10 +416,11 @@ BMenuField::AttachedToWindow()
>                 rgb_color color = parent->ViewColor();
>                 if (color == B_TRANSPARENT_COLOR)
>                         color = ui_color(B_PANEL_BACKGROUND_COLOR);
> +       } else
> +               color = ui_color(B_PANEL_BACKGROUND_COLOR);
>
> -               SetViewColor(color);
> -               SetLowColor(color);
> -       }
> +       SetViewColor(color);
> +       SetLowColor(color);
>  }

Shouldn't this be set to B_MENU_BACKGROUND_COLOR instead of
B_PANEL_BACKGROUND_COLOR? By default they are the set to be the same
color but it is possible the change one or the other.

Other related posts: