[haiku-commits] Re: BRANCH mmadia-github.separate-build-environment - headers/build/posix_target/sys
- From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 06 Aug 2012 00:12:20 +0200
On Sun, 5 Aug 2012 23:49:12 +0200 (CEST)
"mmadia-github.separate-build-environment" <community@xxxxxxxxxxxx> wrote:
> diff --git a/headers/build/posix_target/sys/target_types.h
> b/headers/build/posix_target/sys/target_types.h
> new file mode 100644
> index 0000000..1789705
> --- /dev/null
> +++ b/headers/build/posix_target/sys/target_types.h
[...]
> +/* pthread types */
> +// NOTE: #8730 -- do pointers go inside _HAIKU_BUILD_IDENTIFIER() ?
No.
[...]
> +/* NOTE: #8730 -- is using __haiku_build_haiku_std_[u]int32 correct or
> + would _haiku_build_[u]int32 be correct? */
As usual that depends on what was used before. __haiku_std_uint32 ->
__haiku_build_haiku_std_uint32; __haiku_uint32 -> __haiku_build_haiku_uint32.
> +#ifndef _HAIKU_BUILD_LIBROOT_FUNCTION_WRAPPER
> +/* NOTE: #8730 Just to make sure, are these not needed?
> + Are the libroot versions correct?
> */
> +// /* BSD compatibility */
> +// typedef unsigned _haiku_build_u_long u_long;
> +// typedef unsigned _haiku_build_u_int u_int;
> +// typedef unsigned _haiku_build_u_short u_short;
> +// typedef unsigned _haiku_build_u_char u_char;
> +//
> +//
> +// /* sysV compatibility */
> +// typedef unsigned _haiku_build_ulong ulong;
> +// typedef unsigned _haiku_build_ushort ushort;
> +// typedef unsigned _haiku_build_uint uint;
> +// typedef unsigned _haiku_build_unchar unchar;
To answer the questions: I think they are needed. And yes, the _haiku_build_*
version look OK.
CU, Ingo
Other related posts:
