added 1 changeset to branch 'refs/remotes/mmadia-github/separate-build-environment' old head: a03867b78464c44a2ee305d33184af351c83a761 new head: 3a0888ab8e03b44f6bb023624e0add155e2133be ---------------------------------------------------------------------------- 3a0888a: Updates per mailing list reviews. Thanks for the help, Ingo! [ Matt Madia <mattmadia@xxxxxxxxx> ] ---------------------------------------------------------------------------- Commit: 3a0888ab8e03b44f6bb023624e0add155e2133be Author: Matt Madia <mattmadia@xxxxxxxxx> Date: Sun Aug 5 18:19:21 2012 UTC ---------------------------------------------------------------------------- 1 file changed, 12 insertions(+), 17 deletions(-) headers/build/posix_target/sys/target_types.h | 29 +++++++++------------ ---------------------------------------------------------------------------- diff --git a/headers/build/posix_target/sys/target_types.h b/headers/build/posix_target/sys/target_types.h index 1789705..2188f37 100644 --- a/headers/build/posix_target/sys/target_types.h +++ b/headers/build/posix_target/sys/target_types.h @@ -57,7 +57,6 @@ typedef struct _HAIKU_BUILD_IDENTIFIER(__timer_t)* \ /* pthread types */ -// NOTE: #8730 -- do pointers go inside _HAIKU_BUILD_IDENTIFIER() ? typedef struct _HAIKU_BUILD_IDENTIFIER(_pthread_thread) \ *_HAIKU_BUILD_IDENTIFIER(pthread_t); typedef struct _HAIKU_BUILD_IDENTIFIER(_pthread_attr) \ @@ -87,8 +86,6 @@ typedef struct _HAIKU_BUILD_IDENTIFIER(_pthread_barrierattr) \ *_HAIKU_BUILD_IDENTIFIER(pthread_barrierattr_t); */ -/* NOTE: #8730 -- is using __haiku_build_haiku_std_[u]int32 correct or - would _haiku_build_[u]int32 be correct? */ struct _HAIKU_BUILD_IDENTIFIER(_pthread_mutex) { __haiku_build_haiku_std_uint32 flags; __haiku_build_haiku_std_int32 lock; @@ -131,20 +128,18 @@ struct _HAIKU_BUILD_IDENTIFIER(_pthread_spinlock) { }; #ifndef _HAIKU_BUILD_LIBROOT_FUNCTION_WRAPPER -/* NOTE: #8730 Just to make sure, are these not needed? - Are the libroot versions correct? */ -// /* BSD compatibility */ -// typedef unsigned _haiku_build_u_long u_long; -// typedef unsigned _haiku_build_u_int u_int; -// typedef unsigned _haiku_build_u_short u_short; -// typedef unsigned _haiku_build_u_char u_char; -// -// -// /* sysV compatibility */ -// typedef unsigned _haiku_build_ulong ulong; -// typedef unsigned _haiku_build_ushort ushort; -// typedef unsigned _haiku_build_uint uint; -// typedef unsigned _haiku_build_unchar unchar; + /* BSD compatibility */ + typedef unsigned _haiku_build_u_long u_long; + typedef unsigned _haiku_build_u_int u_int; + typedef unsigned _haiku_build_u_short u_short; + typedef unsigned _haiku_build_u_char u_char; + + + /* sysV compatibility */ + typedef unsigned _haiku_build_ulong ulong; + typedef unsigned _haiku_build_ushort ushort; + typedef unsigned _haiku_build_uint uint; + typedef unsigned _haiku_build_unchar unchar; typedef _haiku_build_blkcnt_t blkcnt_t;