[haiku-bugs] Re: [Haiku] #9920: BSynth upgrade
- From: "jackburton" <trac@xxxxxxxxxxxx>
- Date: Sun, 21 Sep 2014 06:23:54 -0000
#9920: BSynth upgrade
-----------------------------+-------------------------
Reporter: Pete | Owner: korli
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Kits/Midi Kit | Version: R1/alpha4.1
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-----------------------------+-------------------------
Comment (by jackburton):
Replying to [comment:17 jackburton]:
> Replying to [comment:16 Pete]:
> > Replying to [comment:14 jackburton]:
> > > I also applied the reverb part of the patch in hrev47888. What's
missing is the GetAudio part.
> >
> > Thanks, but why did you omit the latter? It seemed to work quite well
in my patch, and it prevents the window in MidiPlayer being annoyingly
inactive...
>
> Just a matter of missing time, and doing one thing at a time. Since I
had to apply the patch manually, I wanted to break down things at the
minimum level.
> I'm applying that part now.
By the way, I just noticed that the GetAudio part breaks binary
compatibility, as you are adding some class members (so changing the class
size). Since there are no reserved items to be used, we can't do that.
--
Ticket URL: <https://dev.haiku-os.org/ticket/9920#comment:19>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
