[haiku-bugs] Re: [Haiku] #8581: Unintended layout change in Filetype add-on

  • From: "yourpalal" <trac@xxxxxxxxxxxx>
  • Date: Wed, 16 May 2012 18:58:16 -0000

#8581: Unintended layout change in Filetype add-on
-------------------------------+----------------------------
   Reporter:  humdinger        |      Owner:  yourpalal
       Type:  enhancement      |     Status:  new
   Priority:  normal           |  Milestone:  R1
  Component:  Add-Ons/Tracker  |    Version:  R1/Development
 Resolution:                   |   Keywords:
 Blocked By:                   |   Blocking:
Has a Patch:  0                |   Platform:  All
-------------------------------+----------------------------

Comment (by yourpalal):

 Replying to [comment:5 humdinger]:
 > Yes, maybe it's just a matter of taste and what one is used to. Though
 axeld has a point seeing the connection between file type/icon and not
 icon/preferred-app.

 It's true that there's some connection, but I think (could be wrong) that
 the icon is just for the specific file, not for all files of that type, so
 maybe it's good to downplay that connection ;) If it's a global change,
 then I would either move the icon view into the FileType box, or remove it
 from the window altogether

 > Anyway, I attached a patch that makes the window a bit wider and pulls
 the icon back to the right of the file type. Unfortunatley resizing the
 window truncates buttons.

 I'm not sure, but you might need to set the last column to have infinite
 max width.

 > I'd be interested to see how to solve that. Also, smaller vertical
 padding of the buttons would be nice... Can't seem to achieve that easily
 either. :}

 {{{
 -  BLayoutBuilder::Grid<>(fileTypeBox)
 +  BLayoutBuilder::Grid<>(fileTypeBox, padding, padding / 2)
 ...
 -  BLayoutBuilder::Grid<>(preferredBox, padding, padding)
 +  BLayoutBuilder::Grid<>(preferredBox, padding, padding / 2)
 }}}

 should do the trick :)

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/8581#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: