[haiku-bugs] Re: [Haiku] #8581: Unintended layout change in Filetype add-on

  • From: "humdinger" <trac@xxxxxxxxxxxx>
  • Date: Thu, 17 May 2012 17:09:32 -0000

#8581: Unintended layout change in Filetype add-on
-------------------------------+----------------------------
   Reporter:  humdinger        |      Owner:  yourpalal
       Type:  enhancement      |     Status:  new
   Priority:  normal           |  Milestone:  R1
  Component:  Add-Ons/Tracker  |    Version:  R1/Development
 Resolution:                   |   Keywords:
 Blocked By:                   |   Blocking:
Has a Patch:  0                |   Platform:  All
-------------------------------+----------------------------

Comment (by humdinger):

 Replying to [comment:6 yourpalal]:
 > It's true that there's some connection, but I think (could be wrong)
 that the icon is just for the specific file, not for all files of that
 type, so maybe it's good to downplay that connection ;) If it's a global
 change, then I would either move the icon view into the FileType box, or
 remove it from the window altogether

 You're right, actually. All three settings are file specific and not
 global. So, where the icon well appears doesn't really matter after all. I
 think having it to the right of the preferred app looks best as all
 buttons are then left aligned.

 > > Anyway, I attached a patch that makes the window a bit wider and pulls
 the icon back to the right of the file type. Unfortunatley resizing the
 window truncates buttons.
 >
 > I'm not sure, but you might need to set the last column to have infinite
 max width.

 How's that done? Your padding hint did the trick. Anyway, not to draw this
 thing out any longer, I updated the FileTypeWindow.diff. Can be applied if
 there's consensus on this bikeshed...

 [[Image(Filetypes_last_version.png)]]

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/8581#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: