[haiku-bugs] Re: [Haiku] #7132: Deskbar Resize Team Icons

#7132: Deskbar Resize Team Icons
-----------------------------------+------------------------------
  Reporter:  jscipione             |        Owner:  axeld
      Type:  enhancement           |       Status:  new
  Priority:  normal                |    Milestone:  R1
 Component:  Applications/Deskbar  |      Version:  R1/Development
Resolution:                        |     Keywords:
Blocked By:                        |  Has a Patch:  1
  Platform:  All                   |     Blocking:
-----------------------------------+------------------------------

Comment (by jscipione):

 Thank you for your feedback axeld!


 >When a new application is launched, the menu entry is only as large as
 the text, and only suddenly grows bigger a bit later -- this doesn't look
 good


 I never noticed that, this is probably due to the icon being fetched at
 the default size (16x16) and then re-sized to the size specified by the
 setting moments later. I'll see if I can get new applications to fetch at
 the size from your settings initially.


 >The icon size choices are pretty arbitrary


 I chose the icon sizes to kinda-sorta match those in Tracker (16x16,
 32x32, 40x40, 48x48, 64x64), however, what I could do is make the slider
 increment by 8px instead of 16px to give you the following size choices:
 16x16, 24x24, 32x32, 40x40, 48x48, 56x56, and 64x64.


 >It doesn't work for the horizontal layout, but never tells you (ie. it
 won't even disable the settings).


 This is true, but I considered it okay because neither do the other
 options like "Show Application Expander" or "Expand New Applications"
 which only work in Vertical Expando mode and yet don't indicate that in
 any way. I guess 2 wrongs do not make a right. Perhaps this would be a
 good time to rethink the preference window layout to indicate which
 options work in which modes.


 >An option to change the width as well would make sense, as the whole
 thing looks strange when its so narrow.


 I was afraid that people would bulk if I changed the width of the Deskbar
 so I left it alone. One issue with the fixed width Deskbar is that at
 larger icon sizes long application names truncate which looks bad. This is
 true even before my patch but was less noticable. I could expand the width
 of the Deskbar proportional to the icon size if you think that would be a
 better solution.


 >I would not store the internal (1) but the actual size (16). One could
 make the size automatically depend on the font size used by default.


 Agreed, I did this only to placate the slider, but you are right, I should
 store the actual icon size.


 >The slider should also set its modification message in order to have a
 live update (instead of only when you release the mouse button).


 I did that in an earlier version of the patch but I reverted it because
 resizing was slow when you had many applications open at once, but, I
 shall enable that once again.


 >in BarApp.cpp line 303 there is no need to wrap the line as the resulting
 line isn't even 80 characters wide (there are other lines there that have
 the same fault, though)


 Yes, I noticed that and copied the mistake of the other lines, I shall fix
 it in the next revision of the patch. I'll also fix the other errors you
 mentioned.


 >The TBarApp::FetchAppIcon() method could be simplified


 I agree, that is much simpler, I will do that.


 >However, this is overridden anyway when you pass 32 bit bitmaps, so you
 can just always specify B_LARGE_ICON.


 This is true only for HVIF-based Haiku icons, not for bitmap-based BeOS
 icons which will use a different bitmap depending on if B_LARGE_ICON or
 B_MINI_ICON is requested.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/7132#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: