[haiku-bugs] Re: [Haiku] #6415: BPictureButton does not draw BPicture
- From: "jackburton" <trac@xxxxxxxxxxxx>
- Date: Wed, 04 Aug 2010 13:13:36 -0000
#6415: BPictureButton does not draw BPicture
-----------------------------+----------------------------------------------
Reporter: laplace | Owner: stippi
Type: bug | Status: closed
Priority: normal | Milestone: R1
Component: User Interface | Version: R1/Development
Resolution: fixed | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
-----------------------------+----------------------------------------------
Comment (by jackburton):
Replying to [comment:7 laplace]:
> Replying to [comment:6 jackburton]:
> > Replying to [comment:5 laplace]:
> > > This fixes the problem of this ticket.
> > >
> > > However the test "Test Draw Scaled Picture" is again where it was
before r37833
> >
> > Yes, of course.
> > I'm having a deeper look to see how to fix the problem without causing
other troubles.
>
> Oh, I didn't realize that this was intended.
>
Sorry, totally my fault. I should have updated the other ticket.
>
> My observation is that the patch attached to this ticket does not have
the clipping problem:
I see. But your patch (the ServerWindow.cpp part) introduces again some
code I had to remove (in r36933) to fix ticket #6070.
I guess that somewhere (in ServerPicture.cpp and/or ServerWindow.cpp) we
use View::SetOrigin() or/and View::Origin() when we should really use
DrawState::DrawingOrigin(), or vice-versa.
--
Ticket URL: <http://dev.haiku-os.org/ticket/6415#comment:8>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
