[dokuwiki] Aw: Re: Re2: Some Patches...
- From: fabidev@xxxxxxxx
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Sat, 15 Mar 2008 22:21:56 +0100 (CET)
> >>> common tools for PHP4.zip
> >>> css improvement.zip
> >>
> > hmm, i had one plugin witch not work in PHP4 (a friend report me the
> > problem on his PHP4 and i make this patch for him)
> > the functions comes from the plugin badbehaviour, this need it for
> > example (are included in it)
> >
>
> You should have included that in your initial patch description. A
> grep of my dev dokuwiki installation shows stripos() calls in two
> third party scripts, simplepie (core) and badbehaviour (plugin). Both
> of these provide their own implementation of the function for
> installations that are missing it. I'm not sure what happened in your
> friend's wiki, but it sure looks like a missing stripos() shouldn't be
> a problem.
Make a test with a background color for this links, by mouse-over, the file
icons disappear (overwritten by the background color, tested with FireFox)
And i think a shown picture deserves his one class, different from normal media
links like zip exe et.
> >>> linebreak.zip
> >>
> > - It down't break "a whole host of test cases", only the Simpel-Test
> > for linebreaks. This is only interesting fore developers, not for
> > users. And a pro developer with knowledge in Simpel-Test fix this in
> > 30 seconds, i think. (i am not a pro developer)
>
> I'm not sure about that. In doing the recent patches to just that
> piece of code I had to fix 30 odd broken tests. Take a look through
> the test case code, it really very easy to follow and consequently
> very easy to write new tests and update old ones.
i will check this once if i finde time, thanks.
i think the Simple-Test has only to set "$conf['linebreak'] = 0" at the
begining.
> > If you see a better cleaner way to implement this option, i am very
> > interested ! :-)
>
> Read recent mails on the topic in the mailing list, get hold of the
> current development version for the complete set of patches.
>
> One of the things to guard against with any piece of software is
> "feature bloat". Where things keep being added to an application to
> satisfy the needs of a particular group of users. As time passes the
> software gets larger and larger, harder and harder to maintain, slower
> and slower. For me DokuWiki hasn't fallen into this trap. It has
> made itself extendable through templates, plugins and settings files
> like acronyms and interwikis.
>
> You might want to take a look at the plugin & template system as a way
> of accomplishing your changes. Its then easier to package up your
> change(s) into a form others can use if they like it. The burden of
> maintaining those changes doesn't transfer to DW itself. If lots of
> people use the template or plugin, you'll have other people who will
> help out with enhancing and maintaining the plugin/template. A patch
> to DW is then only necessary if there is no way to make the
> enhancement without altering the core or to fix a bug.
I now this problem very will :-) unfortunately :-(
Can by i fall in the same trap, but i check carefully what i send you, i have
20 other patches i will never send you ;-) because of this. All i send you is
in my opinion useful for 70% of the users, ...i hope.
Keep in the mind too, the patches are don and work fine for me, to create
public patches for dw cost me only time. Me motivation is to share a little of
the work with the people work mach harder on dw. I down't work here for me
interests.
I will ask the next time first, if "you are interested on a patche like this?",
and if is "no", i let it be. I send now only patches witch are a bug or weakens
in me opinion.
1. question, you want implement the linebreak? If so i search and change the
preset wiki texts for this. (Are TXT ok or you prefer patch?)
Jetzt komfortabel bei Arcor-Digital TV einsteigen: Mehr Happy Ends, mehr
Herzschmerz, mehr Fernsehen! Erleben Sie 50 digitale TV Programme und optional
60 Pay TV Sender, einen elektronischen Programmführer mit Movie Star
Bewertungen von TV Movie. Außerdem, aktuelle Filmhits und prickelnde Erotik in
der Arcor-Videothek. Infos unter www.arcor.de/tv
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist
Other related posts:
- » [dokuwiki] Aw: Re: Re2: Some Patches...
